Add support for generated columns #581
Conversation
There was a problem hiding this comment.
@tooboredtocode hello! Thank you for the PR! Can you add a link to documentation. I have never heard about this column type...
I find an answer. Discussion was on discord: https://discord.com/channels/873880840487206962/900758332187484160/1063039879518359562 |
There was a problem hiding this comment.
@tooboredtocode hello! Sorry for the delay, I had a vacation. LGTM!
|
@tooboredtocode could you resolve conflicts? |
|
@ikrivosheev done 👍 |
|
Thank you. Can we add a doc test? |
|
Where could they be added, i did not find any similar tests where the new tests could fit in. |
| @@ -584,6 +585,18 @@ impl ColumnDef { | |||
| self | |||
| } | |||
|
|
|||
| /// Sets the column as generated with SimpleExpr | |||
| pub fn generated<T>(&mut self, expr: T, stored: bool) -> &mut Self | |||
There was a problem hiding this comment.
A doc test like above would be good https://github.com/tooboredtocode/sea-query/blob/b6adc4b0f18fa24fafa6ac543bf49a4da190758e/src/table/column.rs#L246
🎉 Released In 0.29.0 🎉Your participation is what makes us unique; your adoption is what drives us forward. |
🎉 Released In 0.29.1 🎉Thank you everyone for the contribution! |
New Features
Breaking Changes
This change is backwards compatible