Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get values from update statement #578

Merged
merged 1 commit into from
Jan 12, 2023

Conversation

billy1624
Copy link
Member

@billy1624 billy1624 commented Jan 10, 2023

PR Info

New Features

  • Getter for the UpdateStatement::values field

@billy1624 billy1624 self-assigned this Jan 10, 2023
@billy1624 billy1624 changed the base branch from master to 0.28.x January 10, 2023 14:06
@billy1624 billy1624 marked this pull request as ready for review January 11, 2023 13:34
Copy link
Member

@ikrivosheev ikrivosheev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@billy1624 hello! LGTM!

@ikrivosheev ikrivosheev merged commit 765d603 into 0.28.x Jan 12, 2023
@ikrivosheev ikrivosheev deleted the get-values-from-update-statement branch January 12, 2023 09:52
@ikrivosheev
Copy link
Member

@billy1624 I have updated CHANGELOG.md: https://github.com/SeaQL/sea-query/blob/0.28.x/CHANGELOG.md

And cherry-pick your commit: e63f082

@billy1624
Copy link
Member Author

Thanks!! @ikrivosheev

@@ -314,6 +314,11 @@ impl UpdateStatement {
pub fn with(self, clause: WithClause) -> WithQuery {
clause.query(self)
}

/// Get column values
pub fn get_values(&self) -> &Vec<(DynIden, Box<SimpleExpr>)> {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can this be an &[(DynIden, Box<SimpleExpr>)] instead?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants