Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ValueTuple::Many #564

Merged
merged 2 commits into from
Dec 22, 2022
Merged

ValueTuple::Many #564

merged 2 commits into from
Dec 22, 2022

Conversation

billy1624
Copy link
Member

@billy1624 billy1624 commented Dec 21, 2022

PR Info

New Features

  • Implement ValueTuple::Many for tuple with length up to 12

Breaking Changes

  • ValueTuple::Many is being added to replace all variants after ValueTuple::Three

@billy1624 billy1624 self-assigned this Dec 21, 2022
@billy1624 billy1624 marked this pull request as ready for review December 21, 2022 05:57
@tyt2y3
Copy link
Member

tyt2y3 commented Dec 21, 2022

NB:

    dbg!(std::mem::size_of::<Vec<i64>>());
    dbg!(std::mem::size_of::<(&i64, &i64, &i64)>());
[src/main.rs:2] std::mem::size_of::<Vec<i64>>() = 24
[src/main.rs:3] std::mem::size_of::<(&i64, &i64, &i64)>() = 24

@billy1624 billy1624 mentioned this pull request Dec 21, 2022
8 tasks
@billy1624
Copy link
Member Author

Work as expected :D

Copy link
Member

@ikrivosheev ikrivosheev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@billy1624 hello! Well, It makes sense... LGTM!

@ikrivosheev ikrivosheev merged commit e57ce82 into master Dec 22, 2022
@ikrivosheev ikrivosheev deleted the value-tuple-many branch December 22, 2022 09:22
@github-actions
Copy link

🎉 Released In 0.29.0 🎉

Your participation is what makes us unique; your adoption is what drives us forward.
Thank you all in the Rust community for making SeaQL what it is today. 🦀
You are also invited to shape it's future! Please star our repos, every ⭐ counts!

@github-actions
Copy link

🎉 Released In 0.29.1 🎉

Thank you everyone for the contribution!
This feature is now available in the latest release. Now is a good time to upgrade!
Your participation is what makes us unique; your adoption is what drives us forward.
You can support SeaQL 🌊 by starring our repos, sharing our libraries and becoming a sponsor ⭐.

@tyt2y3
Copy link
Member

tyt2y3 commented Jul 20, 2023

Sorry for the spam lol

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

large composite key table
3 participants