Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change cond_where semantics #417

Merged
merged 4 commits into from
Aug 13, 2022
Merged

Change cond_where semantics #417

merged 4 commits into from
Aug 13, 2022

Conversation

tyt2y3
Copy link
Member

@tyt2y3 tyt2y3 commented Aug 13, 2022

resolves #414

@tyt2y3
Copy link
Member Author

tyt2y3 commented Aug 13, 2022

@e-rhodes

@tyt2y3 tyt2y3 requested a review from ikrivosheev August 13, 2022 04:10
Copy link
Member

@ikrivosheev ikrivosheev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tyt2y3 hello! Some comments)

CHANGELOG.md Show resolved Hide resolved
@tyt2y3 tyt2y3 merged commit 4b280a3 into master Aug 13, 2022
@tyt2y3 tyt2y3 deleted the cond_where branch August 13, 2022 16:49
@Sytten
Copy link
Contributor

Sytten commented Aug 13, 2022

Can we add a test for backward compatibility where you first put a .cond_where(Condition::all()) then a couple of filters.

@tyt2y3
Copy link
Member Author

tyt2y3 commented Aug 13, 2022

Can we add a test for backward compatibility where you first put a .cond_where(Condition::all()) then a couple of filters.

Not quite got that. This is a breaking change, and the behaviour only affect the case where Condition::any() is preceding. I already added some more doc tests. Is that what you need?

Edit: I see your comment in another thread. Okay will do

tyt2y3 added a commit that referenced this pull request Aug 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adding filters after adding a Condition::any in another call results in OR instead of AND
3 participants