issues-383 Create new crate for rusqlite #388
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
billy1624
reviewed
Aug 18, 2022
There was a problem hiding this comment.
Hey @ikrivosheev, sorry for the delay. LGTM!
I'd prefer the rusqlite binder named after sea-query-binder. Maybe sea-query-binder-rustqlite? Btw... I think the sea-query-binder should be renamed to sea-query-binder-sqlx, as suggested by @Sytten at #383 (comment).
Ideas? @ikrivosheev @tyt2y3
|
I agree on the naming. Although it's sad to abandon a crate. May be we can use sea-query-binder as a facade... ah that might be too much since we now have a dependency tree in SeaQuery. |
|
@billy1624 @tyt2y3 hello! I create new PR. Can we move our discussion to: #422? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Info
Adds
rusqlte.