Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

issues-383 Rewrite examples using sea-query-binder #387

Closed
wants to merge 2 commits into from
Closed

issues-383 Rewrite examples using sea-query-binder #387

wants to merge 2 commits into from

Conversation

ikrivosheev
Copy link
Member

PR Info

Changes

  • Rewrite examples using sea-query-binder instead sea-query-driver

@ikrivosheev ikrivosheev requested review from billy1624 and tyt2y3 July 17, 2022 11:42
@ikrivosheev ikrivosheev mentioned this pull request Jul 26, 2022
Closed
10 tasks
@tyt2y3 tyt2y3 added this to the 0.27 milestone Aug 7, 2022
billy1624
billy1624 reviewed Aug 18, 2022
View reviewed changes
Copy link
Member

@billy1624 billy1624 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @ikrivosheev, thanks!!

Nit: you might want run cargofmt, I saw missing space before let xx= xxx. :)

@ikrivosheev
Copy link
Member Author

Hey @ikrivosheev, thanks!!

Nit: you might want run cargofmt, I saw missing space before let xx= xxx. :)

@billy1624, hello! Done

@billy1624 billy1624 linked an issue Aug 19, 2022 that may be closed by this pull request
Deprecate / remove driver in favour of binder #383
Closed
@ikrivosheev ikrivosheev mentioned this pull request Aug 20, 2022
Merged
@ikrivosheev ikrivosheev deleted the feature/issues-383 branch August 20, 2022 11:21
@billy1624 billy1624 removed this from the 0.27.x milestone Aug 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@billy1624 billy1624 billy1624 left review comments

@tyt2y3 tyt2y3 Awaiting requested review from tyt2y3

Assignees

@ikrivosheev ikrivosheev

Labels
None yet
Projects
SeaQL Dev Tracker
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Deprecate / remove driver in favour of binder
3 participants
@ikrivosheev @billy1624 @tyt2y3