Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Making pagination efficient with first function. #298

Closed
wants to merge 1 commit into from

Conversation

arpancodes
Copy link

PR Info

Adds

  • first function to the SelectStatement struct.
  • Corresponding tests for mysql, postgres and sqlite

Improves

This will improve the pagination.

@tyt2y3
Copy link
Member

tyt2y3 commented Apr 9, 2022

I think this PR is opened at the wrong repo. first essentially is the same as limit, so no reason to add it here.
It is more logical to put it in the SeaORM's Selector* structs' API, although if needed you can also add some features to sea-query.

@arpancodes
Copy link
Author

Should I create a new function in paginator.rs @tyt2y3?

@ikrivosheev
Copy link
Member

@tyt2y3 @arpancodes I think we can close this PR?

@tyt2y3
Copy link
Member

tyt2y3 commented Apr 12, 2022

I think we can close this PR?

Agreed

@tyt2y3 tyt2y3 closed this Apr 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cursor Based Pagination
3 participants