issues-969 Replace sea-query-driver to sea-query-binder

[ikrivosheev]

PR Info

• Closes Support sea-query-binder #969

• Dependencies:
  • issues-383 Improve sea-query-binder sea-query#416

Adds

• Replace sea-query-driver to sea-query-binder

[billy1624]

Hey @ikrivosheev, maybe we could get SeaQL/sea-query#416 done then turn our heads back to this?

Btw... I notice a breaking change in the binder of SQLite. The old haviour is to convert rust decimal and big decimal into f64 for binding. However, the new behaviour will simply panic.

thread 'main' panicked at 'Sqlite doesn't support decimal arguments', /home/runner/.cargo/git/checkouts/sea-query-4258bc96379dd872/50ee12e/sea-query-binder/src/sqlx_sqlite.rs:98:21

https://github.com/SeaQL/sea-orm/runs/7913388359?check_suite_focus=true#step:5:300

[billy1624]

Btw... I'm curious if we could avoid the clone by taking ownership of the stmt: Statement?

[ikrivosheev]

I cannot take ownership of the stmt: Statement, because after sqlx_query we needed to send metrics:

#[instrument(level = "trace")]
pub async fn query_all(&self, stmt: Statement) -> Result<Vec<QueryResult>, DbErr> {
    debug_print!("{}", stmt);

    let query = sqlx_query(&stmt);
    if let Ok(conn) = &mut self.pool.acquire().await {
        crate::metric::metric!(self.metric_callback, &stmt, {
            match query.fetch_all(conn).await {
                Ok(rows) => Ok(rows.into_iter().map(|r| r.into()).collect()),
                Err(err) => Err(sqlx_error_to_query_err(err)),
            }
        })
    } else {
        Err(DbErr::Query(
            "Failed to acquire connection from pool.".to_owned(),
        ))
    }
}

[billy1624]

Right!

We can change pub statement: &'a crate::Statement into pub statement: String but then, worse still we need to to_string on Statement ahead of metrics!.

• sea-orm/src/metric.rs

  Lines 8 to 17 in d532deb

  	#[derive(Debug)]
  	/// Query execution infos
  	pub struct Info<'a> {
  	/// Query executiuon duration
  	pub elapsed: Duration,
  	/// Query data
  	pub statement: &'a crate::Statement,
  	/// Query execution failed
  	pub failed: bool,
  	}

So, I'll support as-is - cloning stmt: Statement. Later in time, when we're optimizing for performance, We can move metric utility to compile time, i.e. provide a wrapper to existing connection. So that we don't have to clone Statement even when metric is turned off.

CC @tyt2y3

[ikrivosheev]

Can't do it anyway, because:

pub fn query_with<'q, DB, A>(sql: &'q str, arguments: A) -> Query<'q, DB, A> ...

query_with doesnot take ownership of the query...

[ikrivosheev]

I can make PR for add support QueryOwned into sqlx and this would help us.

[ikrivosheev]

@billy1624 thank you for review. I will return to this PR after merge PRs in SeaQuery.