Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Demonstrate how to mock test SeaORM by separating core implementation from the web API #890

Merged
merged 33 commits into from
Sep 23, 2022

Conversation

shpun817
Copy link
Member

@shpun817 shpun817 commented Jul 19, 2022

PR Info

Adds

@shpun817
Copy link
Member Author

Hey @billy1624, I thought it'd be easier to just take out the core stuff. I wonder if this structure is good enough for the example, or should I add the api crate and put the rocket code in there?

Copy link
Member

@billy1624 billy1624 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @shpun817, the new workspace structure looks exactly like what I'd expect :)

I think we should make it explicit by moving codes that are currently in project root inside the new api crate.

@shpun817
Copy link
Member Author

@billy1624 Finished transforming the Rocket example!

Copy link
Member

@billy1624 billy1624 left a comment

@billy1624
Copy link
Member

Hey @shpun817, @fergus-hou just added an SeaORM example for Salvo. Could we add mock testing to it as well?

@billy1624
Copy link
Member

Ohoh, @shpun817 welcome back!

@shpun817 shpun817 requested a review from billy1624 September 10, 2022 01:00
@shpun817
Copy link
Member Author

@billy1624 Ready for review!

Copy link
Member

@billy1624 billy1624 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @shpun817, thanks for the hard work!!

I have a small refactoring shpun817#3 :)

Copy link
Member

@billy1624 billy1624 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many thanks!! @shpun817

@billy1624 billy1624 requested a review from tyt2y3 September 21, 2022 10:06
@billy1624 billy1624 merged commit 5143307 into SeaQL:master Sep 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

[examples] Demonstrate how to mock test SeaORM's CURD operations on common web APIs
3 participants