Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exclude mock from default features #562

Merged
merged 1 commit into from
Mar 6, 2022
Merged

Exclude mock from default features #562

merged 1 commit into from
Mar 6, 2022

Conversation

billy1624
Copy link
Member

@billy1624 billy1624 commented Mar 1, 2022 •
edited
Loading

PR Info

Breaking Changes

  • Remove mock from default feature
    • This means user who are using mock utilities has to opt-in for it

@billy1624 billy1624 self-assigned this Mar 1, 2022
@billy1624 billy1624 mentioned this pull request Mar 1, 2022
Closed
@billy1624 billy1624 marked this pull request as ready for review March 1, 2022 07:23
@billy1624 billy1624 requested a review from tyt2y3 March 1, 2022 07:24
tyt2y3
tyt2y3 approved these changes Mar 6, 2022
View reviewed changes
Copy link
Member

@tyt2y3 tyt2y3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@tyt2y3 tyt2y3 merged commit 27143a8 into master Mar 6, 2022
@tyt2y3 tyt2y3 deleted the exclude-mock-from-default branch March 6, 2022 14:57
This was referenced Apr 25, 2022
Closed
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tyt2y3 tyt2y3 tyt2y3 approved these changes

Assignees

@billy1624 billy1624

Labels
None yet
Projects
SeaQL Dev Tracker
Archived in project
Milestone
No milestone
2 participants
@billy1624 @tyt2y3