Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Codegen unit test #38

Merged
merged 1 commit into from
Jul 12, 2021
Merged

Codegen unit test #38

merged 1 commit into from
Jul 12, 2021

Conversation

billy1624
Copy link
Member

Unit test #11

@billy1624 billy1624 self-assigned this Jul 6, 2021
@billy1624
Copy link
Member Author

billy1624 commented Jul 6, 2021

Want you @tyt2y3 to review the way I perform unit test

@tyt2y3
Copy link
Member

tyt2y3 commented Jul 6, 2021

Looks good in general.

@billy1624 billy1624 force-pushed the codegen-unit-test branch from b866dbc to ce12fd8 Compare July 7, 2021 15:14
@billy1624
Copy link
Member Author

Ready to merge

@billy1624
Copy link
Member Author

Seems the sea-query rust_decimal issue #34 is not yet resolved?

@tyt2y3
Copy link
Member

tyt2y3 commented Jul 7, 2021

Fixed

@billy1624 billy1624 force-pushed the codegen-unit-test branch from ce12fd8 to 1782441 Compare July 8, 2021 02:05
@billy1624
Copy link
Member Author

Nice, ready to merge then

@tyt2y3 tyt2y3 merged commit a94224e into master Jul 12, 2021
@tyt2y3 tyt2y3 deleted the codegen-unit-test branch July 12, 2021 15:45
SebastienGllmt pushed a commit to dcSpark/sea-orm that referenced this pull request Apr 13, 2022
PR without clippy warmings in file changed tab
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants