First metric and tracing implementation #373
Conversation
|
Awesome! Thank you for the big contribution again. I think tracing has log output support, so we might want to put that shim behind a 'use-log' feature flag. I have no opinion on the trace level, it's good for now. |
What do you mean by "log output support"? |
I found it, I mean this https://docs.rs/tracing/0.1.29/tracing/index.html#log-compatibility |
|
We will release this in |
docs: rework `ActiveValue` (SeaQL/sea-orm#340) docs: schema_name will always be applied (SeaQL/sea-orm#370) docs: `ActiveModelBehavior::after_save` takes `Model` (SeaQL/sea-orm#339) docs: `Schema::create_enum_from_active_enum` (SeaQL/sea-orm#348) docs: `ModelTrait::delete` (SeaQL/sea-orm#396) docs: codegen SQLite (SeaQL/sea-orm#386) docs: unsigned integers (SeaQL/sea-orm#397) docs: debug log (SeaQL/sea-orm#373) blog: draft "What's new in SeaORM 0.5.0" docs: revert `save` to return Self (SeaQL/sea-orm@d5c9c65) Revert "docs: unsigned integers (SeaQL/sea-orm#397)" This reverts commit ac6d49e. docs: exclude SeaQL/sea-orm#397 in 0.5.0 blog post docs: update landing page examples docs: edit docs: edit docs: fix 0.4.x docs link build: bump docusaurus version to 2.0.0-beta.14
As discussed on #372, I've done a first, minimal, implementation for tracing and metric support.
I'm actually using this version on my environment and it seems to works like a charm, especially the metric part.
For the Tracing part, I've instrumented a minimal part of crate methods, and I've decided to instrument it as level trace because I think a library crate should not be "too loud".
Maybe we could control that behavior with a feature if you prefer