Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix clippy warnings on 1.75 #2057

Merged
merged 1 commit into from
Jan 10, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion sea-orm-macros/src/strum/helpers/mod.rs
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
pub use self::case_style::CaseStyleHelpers;
pub use self::type_props::HasTypeProperties;
pub use self::variant_props::HasStrumVariantProperties;

Expand Down
4 changes: 4 additions & 0 deletions src/driver/mock.rs
Original file line number Diff line number Diff line change
Expand Up @@ -117,6 +117,10 @@ impl MockDatabaseConnection {
}

/// Get the [DatabaseBackend](crate::DatabaseBackend) being used by the [MockDatabase]
///
/// # Panics
///
/// Will panic if the lock cannot be acquired.
pub fn get_database_backend(&self) -> DbBackend {
self.mocker
.lock()
Expand Down
1 change: 1 addition & 0 deletions src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -345,6 +345,7 @@ pub mod tests_cfg;
mod util;

pub use database::*;
#[allow(unused_imports)]
pub use driver::*;
pub use entity::*;
pub use error::*;
Expand Down
1 change: 0 additions & 1 deletion src/query/combine.rs
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@ use crate::{
ColumnTrait, EntityTrait, IdenStatic, Iterable, QueryTrait, Select, SelectTwo, SelectTwoMany,
};
use core::marker::PhantomData;
pub use sea_query::JoinType;
use sea_query::{Alias, ColumnRef, Iden, Order, SeaRc, SelectExpr, SelectStatement, SimpleExpr};

macro_rules! select_def {
Expand Down
1 change: 0 additions & 1 deletion src/query/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@ pub use combine::{SelectA, SelectB};
pub use delete::*;
pub use helper::*;
pub use insert::*;
pub use join::*;
#[cfg(feature = "with-json")]
pub use json::*;
pub use loader::*;
Expand Down
1 change: 0 additions & 1 deletion src/query/select.rs
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
use crate::{ColumnTrait, EntityTrait, Iterable, QueryFilter, QueryOrder, QuerySelect, QueryTrait};
use core::fmt::Debug;
use core::marker::PhantomData;
pub use sea_query::JoinType;
use sea_query::{Expr, IntoColumnRef, SelectStatement, SimpleExpr};

/// Defines a structure to perform select operations
Expand Down
21 changes: 12 additions & 9 deletions tests/active_enum_tests.rs
Original file line number Diff line number Diff line change
@@ -1,14 +1,15 @@
pub mod common;

use active_enum::Entity as ActiveEnum;
use active_enum_child::Entity as ActiveEnumChild;
use active_enum::Entity as ActiveEnumEntity;
pub use common::{features::*, setup::*, TestContext};
use pretty_assertions::assert_eq;
#[cfg(feature = "sqlx-postgres")]
use sea_orm::QueryTrait;
use sea_orm::{
entity::prelude::*,
entity::*,
sea_query::{BinOper, Expr},
ActiveEnum as ActiveEnumTrait, DatabaseConnection, QueryTrait,
ActiveEnum as ActiveEnumTrait, DatabaseConnection,
};

#[sea_orm_macros::test]
Expand Down Expand Up @@ -146,6 +147,7 @@ pub async fn insert_active_enum(db: &DatabaseConnection) -> Result<(), DbErr> {
let select_with_tea_not_in = Entity::find()
.filter(Column::Tea.is_not_null())
.filter(Column::Tea.is_not_in([Tea::BreakfastTea]));

#[cfg(feature = "sqlx-postgres")]
assert_eq!(
select_with_tea_not_in
Expand All @@ -162,6 +164,7 @@ pub async fn insert_active_enum(db: &DatabaseConnection) -> Result<(), DbErr> {
]
.join(" ")
);

assert_eq!(model, select_with_tea_not_in.one(db).await?.unwrap());

let res = model.delete(db).await?;
Expand Down Expand Up @@ -338,7 +341,7 @@ pub async fn find_related_active_enum(db: &DatabaseConnection) -> Result<(), DbE
}]
);
assert_eq!(
ActiveEnum::find()
ActiveEnumEntity::find()
.find_with_related(ActiveEnumChild)
.all(db)
.await?,
Expand All @@ -359,7 +362,7 @@ pub async fn find_related_active_enum(db: &DatabaseConnection) -> Result<(), DbE
)]
);
assert_eq!(
ActiveEnum::find()
ActiveEnumEntity::find()
.find_also_related(ActiveEnumChild)
.all(db)
.await?,
Expand Down Expand Up @@ -464,7 +467,7 @@ pub async fn find_linked_active_enum(db: &DatabaseConnection) -> Result<(), DbEr
}]
);
assert_eq!(
ActiveEnum::find()
ActiveEnumEntity::find()
.find_also_linked(active_enum::ActiveEnumChildLink)
.all(db)
.await?,
Expand All @@ -485,7 +488,7 @@ pub async fn find_linked_active_enum(db: &DatabaseConnection) -> Result<(), DbEr
)]
);
assert_eq!(
ActiveEnum::find()
ActiveEnumEntity::find()
.find_with_linked(active_enum::ActiveEnumChildLink)
.all(db)
.await?,
Expand Down Expand Up @@ -620,7 +623,7 @@ mod tests {
.join(" ")
);

let _select = ActiveEnum::find().find_also_related(ActiveEnumChild);
let _select = ActiveEnumEntity::find().find_also_related(ActiveEnumChild);
#[cfg(any(feature = "sqlx-mysql", feature = "sqlx-sqlite"))]
{
assert_eq!(
Expand Down Expand Up @@ -707,7 +710,7 @@ mod tests {
.join(" ")
);

let _select = ActiveEnum::find().find_also_linked(active_enum::ActiveEnumChildLink);
let _select = ActiveEnumEntity::find().find_also_linked(active_enum::ActiveEnumChildLink);
#[cfg(any(feature = "sqlx-mysql", feature = "sqlx-sqlite"))]
{
assert_eq!(
Expand Down
6 changes: 1 addition & 5 deletions tests/common/features/json_vec.rs
Original file line number Diff line number Diff line change
Expand Up @@ -22,11 +22,7 @@ impl TryGetableFromJson for StringVec {}

impl From<StringVec> for Value {
fn from(source: StringVec) -> Self {
sea_orm::Value::Json(
serde_json::to_value(&source)
.ok()
.map(|s| std::boxed::Box::new(s)),
)
sea_orm::Value::Json(serde_json::to_value(source).ok().map(std::boxed::Box::new))
}
}

Expand Down
1 change: 0 additions & 1 deletion tests/common/setup/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,6 @@ pub async fn tear_down(base_url: &str, db_name: &str) {
format!("DROP DATABASE IF EXISTS \"{db_name}\";"),
))
.await;
} else {
};
}

Expand Down
11 changes: 4 additions & 7 deletions tests/cursor_tests.rs
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,7 @@ pub mod common;

pub use common::{features::*, setup::*, TestContext};
use pretty_assertions::assert_eq;
use sea_orm::{
entity::prelude::*, DerivePartialModel, FromQueryResult, QueryOrder, QuerySelect, Set,
};
use sea_orm::{entity::prelude::*, DerivePartialModel, FromQueryResult, QuerySelect, Set};
use serde_json::json;

#[sea_orm_macros::test]
Expand All @@ -18,7 +16,7 @@ async fn main() -> Result<(), DbErr> {
create_tables(&ctx.db).await?;
create_insert_default(&ctx.db).await?;
cursor_pagination(&ctx.db).await?;
schema::create_tables(&ctx.db).await?;
bakery_chain_schema::create_tables(&ctx.db).await?;
create_baker_cake(&ctx.db).await?;
cursor_related_pagination(&ctx.db).await?;
ctx.delete().await;
Expand Down Expand Up @@ -281,7 +279,8 @@ pub async fn cursor_pagination(db: &DatabaseConnection) -> Result<(), DbErr> {
}

use common::bakery_chain::{
baker, bakery, cake, cakes_bakers, schema, Baker, Bakery, Cake, CakesBakers,
baker, bakery, cake, cakes_bakers, schema as bakery_chain_schema, Baker, Bakery, Cake,
CakesBakers,
};

fn bakery(i: i32) -> bakery::Model {
Expand Down Expand Up @@ -318,8 +317,6 @@ fn cakebaker(cake: char, baker: char) -> CakeBakerlite {
}

pub async fn create_baker_cake(db: &DatabaseConnection) -> Result<(), DbErr> {
use sea_orm::IntoActiveModel;

let mut bakeries: Vec<bakery::ActiveModel> = vec![];
// bakeries named from 1 to 10
for i in 1..=10 {
Expand Down
3 changes: 1 addition & 2 deletions tests/empty_insert_tests.rs
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@ pub use sea_orm::{
pub use crud::*;
// use common::bakery_chain::*;
use sea_orm::{DbConn, TryInsertResult};
use sea_query::OnConflict;

#[sea_orm_macros::test]
#[cfg(any(
Expand Down Expand Up @@ -38,7 +37,7 @@ pub async fn test(db: &DbConn) {

assert!(matches!(res, Ok(TryInsertResult::Inserted(_))));

let double_seaside_bakery = bakery::ActiveModel {
let _double_seaside_bakery = bakery::ActiveModel {
name: Set("SeaSide Bakery".to_owned()),
profit_margin: Set(10.4),
id: Set(1),
Expand Down
2 changes: 1 addition & 1 deletion tests/returning_tests.rs
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@ async fn main() -> Result<(), DbErr> {
should_panic(expected = "Database backend doesn't support RETURNING")
)]
async fn update_many() {
pub use common::{features::*, setup::*, TestContext};
pub use common::{features::*, TestContext};
use edit_log::*;

let run = || async {
Expand Down