Add unit test for pagination

[billy1624]

#5

[billy1624]

Why cant I mark the PR as draft?

[tyt2y3]

Perhaps you can only create a draft when it is being opened.

[tyt2y3]

Shouldn't we include an empty page3?

[billy1624]

Ah... this will solve the issue

[tyt2y3]

Yes, we should be able to impl From<M: ModelTrait> for MockRow
And don't forget to assert also the SQL query by into_transaction_log

[billy1624]

And don't forget to assert also the SQL query by into_transaction_log

Seems that I cannot get the transaction log from MockDatabase once it turns into Database.

[tyt2y3]

Well, that's bad. Because it is hidden behind a dyn trait.
We can only add the into_transaction_log method to the trait interface.
And then we can take that back out via the connection.

[billy1624]

Well, that's bad. Because it is hidden behind a dyn trait.

Yes :(

[billy1624]

How about adding a feature gated into_transaction_log() on Database trait

[tyt2y3]

Well, that's an official API, which would be another story.

[billy1624]

What's your plan on this?

[tyt2y3]

add the into_transaction_log method to the MockDatabaseTrait trait

[billy1624]

Then we have both DatabaseTrait and MockDatabaseTrait implementing some CommonDatabaseTrait?

[tyt2y3]

It can be accessed via MockDatabaseConnection

[billy1624]

Hmmmm.... okay

match db.get_connection() {
    crate::DatabaseConnection::MockDatabaseConnection(mock_conn) => {

    },
    _ => unreachable!(),
};

[billy1624]

I guess this is intensional. So that once we got the test cases setup we can run it directly on Postgres.

sea-orm/src/database/connection.rs

Line 60 in 97faaf0

DatabaseConnection::MockDatabaseConnection(_) => QueryBuilderBackend::Postgres,

[billy1624]

See latest commit for transaction log checking

[tyt2y3]

Intentional. Just wanna try out different syntax to increase test coverage.

[billy1624]

Actually the test case can be run against any live & mock connection loll

sea-orm/src/executor/paginator.rs

Lines 355 to 384 in 7fa7463

	#[async_std::test]
	async fn into_stream() -> Result<(), QueryErr> {
	let (db, pages) = setup();
	let mut fruit_stream = fruit::Entity::find().paginate(&db, 2).into_stream();
	assert_eq!(fruit_stream.try_next().await?, Some(pages[0].clone()));
	assert_eq!(fruit_stream.try_next().await?, Some(pages[1].clone()));
	assert_eq!(fruit_stream.try_next().await?, None);
	drop(fruit_stream);
	let select = SelectStatement::new()
	.exprs(vec![
	Expr::tbl(fruit::Entity, fruit::Column::Id),
	Expr::tbl(fruit::Entity, fruit::Column::Name),
	Expr::tbl(fruit::Entity, fruit::Column::CakeId),
	])
	.from(fruit::Entity)
	.to_owned();
	let transaction_log = vec![
	select.clone().offset(0).limit(2).to_owned(),
	select.clone().offset(2).limit(2).to_owned(),
	select.clone().offset(4).limit(2).to_owned(),
	];
	match_transaction_log(db, transaction_log);
	Ok(())
	}

[tyt2y3]

How to refactor and improve the ergonomic for using the Mock API?

[billy1624]

What u mean?

For example...

• auto generate impl From for Model
• IntoMockRow trait

[tyt2y3]

Yup, make the interface smooth

[billy1624]

Ok, will think about it

[billy1624]

Btw... we can explore the possibility to run our test cases against any real & mock connection

E.g. type def a connection for all test cases to use

[billy1624]

I have created a match_transaction_log macro to support transaction log checking against select, update, delete and insert statement.

sea-orm/src/util.rs

Lines 27 to 38 in 5ef7c2d

	#[macro_export]
	macro_rules! match_transaction_log {
	($logs:expr, $stmts:expr, $query_builder:expr, $build_method:ident) => {
	for stmt in $stmts.iter() {
	assert!(!$logs.is_empty());
	let log = $logs.first().unwrap();
	let statement = $query_builder.$build_method(stmt);
	assert_eq!(log.to_string(), statement.to_string());
	$logs = $logs.drain(1..).collect();
	}
	};
	}

Use it as follows

sea-orm/src/executor/paginator.rs

Lines 353 to 361 in 5ef7c2d

	let stmts = vec![
	select.clone().offset(0).limit(2).to_owned(),
	select.clone().offset(2).limit(2).to_owned(),
	select.clone().offset(4).limit(2).to_owned(),
	];
	let query_builder = db.get_query_builder_backend();
	let mut logs = get_mock_transaction_log(db);
	match_transaction_log!(logs, stmts[0..1], query_builder, build_select_statement);
	match_transaction_log!(logs, stmts[1..], query_builder, build_select_statement);

[billy1624]

What u mean?

For example...

• auto generate impl From for Model
• IntoMockRow trait

Both added

[tyt2y3]

Macro is not approved

[billy1624]

Macro is not approved

I guess u mean the derive macro

Instead of using derive macro, we can...

https://github.com/SeaQL/sea-orm/blob/aa412016777e171d48cd02a93e23cb3f3bf6b8a9/src/tests_cfg/util.rs

[tyt2y3]

I mean both derive and match_transaction_log
I don't see a necessity for those.

[billy1624]

I mean both derive and match_transaction_log
I don't see a necessity for those.

Just to avoid boilerplate

[billy1624]

Will expand the macro then loll

[tyt2y3]

There must exist better ways to improve the ergonomic without using any macro

[billy1624]

Can we add a fn in MockDatabase? Take in any Statement and match it against first row of transaction_log

i.e. calling assert_eq!() in MockDatabase API

Is this good?

[billy1624]

Can we add a fn in MockDatabase? Take in any Statement and match it against first row of transaction_log

i.e. calling assert_eq!() in MockDatabase API

Is this good?

See latest commit