Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: regex dependency in sea-orm-cli should have unicode feature enabled #1605

Merged
merged 1 commit into from
Apr 21, 2023
Merged

fix: regex dependency in sea-orm-cli should have unicode feature enabled #1605

merged 1 commit into from
Apr 21, 2023

Conversation

billy1624
Copy link
Member

@billy1624 billy1624 self-assigned this Apr 21, 2023
@billy1624 billy1624 marked this pull request as ready for review April 21, 2023 16:56
@billy1624
Copy link
Member Author

The failing CI: https://github.com/SeaQL/sea-orm/actions/runs/4766930667/jobs/8474571915#step:5:300

@billy1624 billy1624 merged commit 41d9a85 into master Apr 21, 2023
@billy1624 billy1624 deleted the fix-cli-regex-unicode-features branch April 21, 2023 17:03
@dbidwell94
Copy link

Excellent :)

@dbidwell94
Copy link

However, this PR is just about ready to go: tokio-rs/tracing#2566

@dbidwell94
Copy link

Ah, nvm. Regex is an actual dependency in this, belay my last :)

@billy1624
Copy link
Member Author

Actually, this is not needed after the release of tracing-subscriber 0.3.17. But we better keep it.

billy1624 added a commit that referenced this pull request Apr 24, 2023
@billy1624
Revert "fix: regex dep should enable unicode feature (#1605)"
056ccc8 
This reverts commit 41d9a85.
billy1624 added a commit that referenced this pull request Apr 24, 2023
@billy1624
Upgrade tracing-subscriber dependency to 0.3.17 (#1609)
9ca01b3 
* Upgrade `tracing-subscriber` dependency to 0.3.17

* Revert "fix: `regex` dep should enable `unicode` feature (#1605)"

This reverts commit 41d9a85.
billy1624 added a commit that referenced this pull request Apr 24, 2023
@billy1624
Upgrade tracing-subscriber dependency to 0.3.17 (#1609)
1a275d6 
* Upgrade `tracing-subscriber` dependency to 0.3.17

* Revert "fix: `regex` dep should enable `unicode` feature (#1605)"

This reverts commit 41d9a85.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@billy1624 billy1624

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@billy1624 @dbidwell94