Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes sea-orm-cli exit status #1402

Merged
merged 1 commit into from
Jan 19, 2023
Merged

Fixes sea-orm-cli exit status #1402

merged 1 commit into from
Jan 19, 2023

Conversation

Diwakar-Gupta
Copy link
Contributor

@Diwakar-Gupta Diwakar-Gupta commented Jan 18, 2023

PR Info

Fixes issue #1342

Bug Fixes

If Command::new child process exits with non 0 exit code then propagate error.

Changes

changes 2 files
sea-orm-cli/src/commands/migrate.rs and sea-orm-cli/src/commands/generate.rs

@Diwakar-Gupta Diwakar-Gupta force-pushed the master branch 2 times, most recently from 2408bf9 to 671eb8e Compare January 19, 2023 06:39
Copy link
Member

@billy1624 billy1624 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!! @Diwakar-Gupta Clean & neat!

@billy1624 billy1624 merged commit 9c6e5c1 into SeaQL:master Jan 19, 2023
@Diwakar-Gupta
Copy link
Contributor Author

Thanks @billy1624 for helping me with the PR.

@billy1624 billy1624 linked an issue Jan 19, 2023 that may be closed by this pull request
@billy1624
Copy link
Member

Happy to help! Feel free to pick another issue to work on :)
See you around

denwong47 pushed a commit to denwong47/sea-orm that referenced this pull request Jan 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

sea-orm-cli errors exit with error code 0
2 participants