-
-
Notifications
You must be signed in to change notification settings - Fork 521
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactoring Schema to expose functions for database updates #1256
refactoring Schema to expose functions for database updates #1256
Conversation
…ailable for database upgrade processes.
Good to have this feature |
Hey @mohs8421, thanks for contributing!! Seems this PR is still in progress and there are more internal functions to be extracted and made public? Let me know when it's ready :) |
yes, I want to extract the part about foreign keys as well, it should be almost straight forward too, although the confusion about |
… into From<RelationDef> implementations to make its usage easier in different context, like updating a database.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @mohs8421, looks good! I've a small refactoring mohs8421#1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Opppps... sorry, I forgot to set the name of the target table
mohs8421#2
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅
This PR aims to expose functionality already available within a Schema to make it easier to update databases after changes.
Changes
get_column_def()
to make the creation ofTableAlterStatement
easier in migrations