Cli serde skip deserialize for primary key option #1186
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsar-boomba
changed the title
billy1624
approved these changes
Dec 19, 2022
There was a problem hiding this comment.
Hey @tsar-boomba, sorry for the delay. Looks good to me. I'll merge this into a local branch where I'd like to refactor some lines before it goes into master branch.
Thanks @Witcher01 again for the initial contributions
|
Glad to be able to improve this great project! 😁 |
|
Thanks for the contributions and the big support!! :) |
billy1624
added a commit
that referenced
this pull request
Dec 19, 2022
* Cli serde skip deserialize for primary key option (#1186) * Add CLI option to skip primary keys with serde Implements: #841 * Codegen: fix tests * complete skip_deserialize cli feature * run fmt * fix tests Co-authored-by: witcher <[email protected]> * [cli] should be `#[serde(skip_deserializing)]` * [CLI] code refactor * [cli] rename Co-authored-by: Isaiah Gamble <[email protected]> Co-authored-by: witcher <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Info
Continuation of #846. The contributor couldn't finish it so I did.
Closes
New Features
--skip-primary-key-deserializationflag for cli