-
-
Notifications
You must be signed in to change notification settings - Fork 527
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Support deriving ActiveEnum without importing some types #1146
fix: Support deriving ActiveEnum without importing some types #1146
Conversation
sea-orm-macros/src/lib.rs
Outdated
/// # Usage | ||
/// | ||
/// ``` | ||
/// use sea_orm::{sea_query, EnumIter, DeriveActiveEnum}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now we do not need to import Iden, EnumIter nor ActiveEnum, but sea_query is still needed.
Hi @billy1624 , thank you for triaging this pull request! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @siketyan, thanks for helping!!
Hi @billy1624 , thank you for triaging this pull request! I think #1151 will NOT be resolved by this changes.
Yes, you're correct! I'm thing rewriting the derive macros, without using sea_query::Iden
derive macros.
Would you mind if I merge your PR into another local branch so I can work on top of your work?
I'll create a PR to fix both issues and ask for your help to validate the fix did works. Thanks in advance!! :)
Sure, of course! |
PR Info
Adds
N/A
Fixes
sea_orm::
prefix to enable derives without importing the typessea_orm::sea_query
or depending onsea_query
crate is still needed due to types derived insea_query_derive
crateBreaking Changes
N/A
Changes
N/A