Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Trim spaces when paginating raw SQL #1094

Merged
merged 1 commit into from
Oct 6, 2022
Merged

Trim spaces when paginating raw SQL #1094

merged 1 commit into from
Oct 6, 2022

Conversation

billy1624
Copy link
Member

PR Info

Fixes

  • When turning raw SQL into paginated select. We should first trim spaces especially leading spaces before substring.

@billy1624 billy1624 self-assigned this Oct 6, 2022
@billy1624 billy1624 mentioned this pull request Oct 6, 2022
Closed
@billy1624 billy1624 marked this pull request as ready for review October 6, 2022 09:31
@billy1624 billy1624 requested a review from tyt2y3 October 6, 2022 09:31
@tyt2y3 tyt2y3 merged commit 5f16703 into master Oct 6, 2022
@tyt2y3 tyt2y3 deleted the paginate-raw-sql-trim-spaces branch October 6, 2022 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tyt2y3 tyt2y3 Awaiting requested review from tyt2y3

Assignees

@billy1624 billy1624

Labels
None yet
Projects
SeaQL Dev Tracker
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Raw Sql + Paginate results in double SELECT statements
2 participants
@billy1624 @tyt2y3