Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Escape Rust keywords used in table names #1052

Merged
merged 2 commits into from
Oct 26, 2022
Merged

Escape Rust keywords used in table names #1052

merged 2 commits into from
Oct 26, 2022

Conversation

andy128k
Copy link
Contributor

@andy128k andy128k marked this pull request as ready for review September 18, 2022 14:08
@billy1624 billy1624 mentioned this pull request Sep 20, 2022
Merged
billy1624
billy1624 reviewed Sep 20, 2022
View reviewed changes
Copy link
Member

@billy1624 billy1624 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @andy128k, thanks for the investigating and quick fix. Looks good to me but we need to make one more change. Please review and merge andy128k#1 Thanks!!

@billy1624 billy1624 mentioned this pull request Sep 20, 2022
Closed
billy1624
billy1624 approved these changes Sep 21, 2022
View reviewed changes
Copy link
Member

@billy1624 billy1624 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!! @andy128k

tyt2y3
tyt2y3 approved these changes Oct 11, 2022
View reviewed changes
Copy link
Member

@tyt2y3 tyt2y3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Appreciated

@tyt2y3
Copy link
Member

tyt2y3 commented Oct 16, 2022

Feel free to merge

@tyt2y3 tyt2y3 assigned billy1624 and unassigned andy128k Oct 23, 2022
@billy1624 billy1624 merged commit 7e92876 into SeaQL:master Oct 26, 2022
@andy128k andy128k deleted the issue_1051 branch October 26, 2022 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@billy1624 billy1624 billy1624 approved these changes

@tyt2y3 tyt2y3 tyt2y3 approved these changes

Assignees

@billy1624 billy1624

Labels
None yet
Projects
SeaQL Dev Tracker
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

sea-orm-cli generates invalid code when table name is a Rust keyword
3 participants
@andy128k @tyt2y3 @billy1624