Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: docs grammar fix #1050

Merged
merged 5 commits into from
Sep 27, 2022
Merged

Chore: docs grammar fix #1050

merged 5 commits into from
Sep 27, 2022

Conversation

tusharxoxoxo
Copy link
Contributor

@tusharxoxoxo tusharxoxoxo commented Sep 18, 2022

PR Info

  • Closes
  • Dependencies:
  • Dependents:

Adds

Fixes

Breaking Changes

Changes

  • Fixed few grammatical errors

@tusharxoxoxo
Copy link
Contributor Author

anyone
I am new to this
can someone guide how to it??

Copy link
Member

@billy1624 billy1624 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @tusharxoxoxo, welcome and thanks for the proofreading!!
You even proofread the CHANGELOG :D

@billy1624 billy1624 requested a review from tyt2y3 September 19, 2022 11:02
@tusharxoxoxo
Copy link
Contributor Author

I was unable to find a better way
to kill my time other that this

@tusharxoxoxo
Copy link
Contributor Author

Now, what should I do after u have assigned me this ??

Copy link
Member

@billy1624 billy1624 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @tusharxoxoxo, the changes look good to me. Now let's wait @tyt2y3 to review and merge it. Thanks!!

Copy link
Member

@tyt2y3 tyt2y3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much for the chore

@tyt2y3
Copy link
Member

tyt2y3 commented Sep 27, 2022

I think Billy 'assigns' a PR to someone when it's not on his stack anymore.

@tyt2y3 tyt2y3 merged commit 55f16ec into SeaQL:master Sep 27, 2022
tyt2y3 pushed a commit that referenced this pull request Sep 30, 2022
* Update DESIGN.md

* Update CONTRIBUTING.md

* Update COMMUNITY.md

* Update COMMUNITY.md

* Update CHANGELOG.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants