- Sponsor
-
Notifications
You must be signed in to change notification settings - Fork 531
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create Table Statement #102
Conversation
Hey @bobbyng626, can you add some test cases? I saw you got some for debugging during development. E.g. asserting the output of |
20580c3
to
8ce4b0a
Compare
2d2fff7
to
6847dab
Compare
Thinking should we include |
Seemingly yes |
We don't have to change the codegen for now. I think it's worth to add because then we don't have to modify the original test cases. |
Btw... why we have a seperate I guess you don't want to expose Like I did for pub type ForeignKeyAction = sea_query::ForeignKeyAction; |
Two reasons:
So either we break SeaQuery, or we have to do the extra mapping in SeaORM. |
Cargo.toml
Outdated
@@ -32,7 +32,7 @@ futures = { version = "^0.3" } | |||
futures-util = { version = "^0.3" } | |||
rust_decimal = { version = "^1", optional = true } | |||
sea-orm-macros = { version = "^0.1.1", optional = true } | |||
sea-query = { version = "^0.15", features = ["thread-safe"] } | |||
sea-query = { version = "^0.15", git = "https://github.com/SeaQL/sea-query.git", features = ["thread-safe"] } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use sea-query on crates.io after new version published
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yea 0.16 is coming
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#59