Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DeriveRelation on empty Relation enum #1019

Merged
merged 1 commit into from
Sep 25, 2022
Merged

DeriveRelation on empty Relation enum #1019

merged 1 commit into from
Sep 25, 2022

Conversation

billy1624
Copy link
Member

@billy1624 billy1624 commented Sep 8, 2022 •
edited
Loading

PR Info

Changes

  • Codegen will append DeriveRelation to Relation enum and skip impl RelationTrait for Relation block

@billy1624 billy1624 self-assigned this Sep 8, 2022
@billy1624 billy1624 force-pushed the derive-relation-on-empty-enum branch from 2502e6d to fed345c Compare September 8, 2022 08:08
@billy1624 billy1624 force-pushed the derive-relation-on-empty-enum branch from fed345c to dcf044f Compare September 8, 2022 08:31
@billy1624 billy1624 marked this pull request as ready for review September 8, 2022 08:31
@billy1624 billy1624 requested a review from tyt2y3 September 8, 2022 08:31
@billy1624 billy1624 merged commit 6ba8e1b into master Sep 25, 2022
@billy1624 billy1624 deleted the derive-relation-on-empty-enum branch September 25, 2022 02:17
billy1624 added a commit that referenced this pull request Sep 25, 2022
@billy1624
CHANGELOG (#1019)
597f515
tyt2y3 pushed a commit that referenced this pull request Sep 30, 2022
@billy1624 @tyt2y3
DeriveRelation on empty Relation enum (#1019)
ff56b5d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tyt2y3 tyt2y3 Awaiting requested review from tyt2y3

Assignees

@billy1624 billy1624

Labels
None yet
Projects
SeaQL Dev Tracker
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

DeriveRelation can be used on empty Relation enum
1 participant
@billy1624