Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#86 Test #100

Closed
wants to merge 1 commit into from
Closed

#86 Test #100

wants to merge 1 commit into from

Conversation

tyt2y3
Copy link
Member

@tyt2y3 tyt2y3 commented Aug 21, 2021

Just for experimenting why Arc is necessary.

@tyt2y3 tyt2y3 marked this pull request as draft August 22, 2021 16:41
@tyt2y3
Copy link
Member Author

tyt2y3 commented Aug 22, 2021 •
edited
Loading

It does not seem to fail with the updated test suite
@acidic9 can you advice how to actually reproduce the original error?

@tqwewe
Copy link
Contributor

tqwewe commented Aug 23, 2021 •
edited
Loading

@tyt2y3 Did you try the comment I posted here? #86 (comment)

@tyt2y3
Copy link
Member Author

tyt2y3 commented Aug 23, 2021

@tyt2y3 Did you try the comment I posted here? #86 (comment)

Thanks I reproduced it now. Okay so the key is tokio::spawn.

@tyt2y3 tyt2y3 force-pushed the master branch 2 times, most recently from a90177b to 8cfa142 Compare August 23, 2021 07:40
@tyt2y3 tyt2y3 closed this Aug 24, 2021
@tyt2y3 tyt2y3 deleted the thread-safe branch October 1, 2021 04:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tyt2y3 @tqwewe