Let breadcrumb texts be dynamic if needed #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
January 29, 2018 11:55
In doing so it's possible to e.g. update the breadcrumbs when changing the language.
|
Adapted code to your code style. |
tztz
changed the title
|
When do you plan to update the corresponding npm package? Cheers! |
|
@tztz already) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
In order that breadcrumbs can change their texts dynamically, e.g. when changing the display language (i18n), also functions should be allowed as breadcrumb value.
This feature is fully backwards compatible. It just adds the means to also use functions as values.
The README is updated as well to reflect sample usage.