Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

package.json updates #217

Closed
wants to merge 3 commits into from
Closed

package.json updates #217

wants to merge 3 commits into from

Conversation

dvdjms
Copy link
Contributor

@dvdjms dvdjms commented Oct 4, 2024

Description

  • Please include a summary of the change and which issue is fixed.
  • List any dependencies that are required for this change.

Fixes # (issue number)

Type of change

Please delete options that are not relevant

  • [] Bug fix (non-breaking change which fixes an issue)
  • [] New Feature (non-breaking change which adds functionality)
  • [] Breaking change(fix or feature that would cause existing functionality to not work as expected)
  • [] This change requires a documentation update

Testing locally

  • Add here anything someone would need to do to test your code locally, or delete this section if nothing needed
  • E.g. run npm install in the app, refresh the database, look at a particular project that has a video, add a .env file value (NB do not share any sensitive details here as PRs are public)

Checklist

  • [] My code follows the style guidelines of this project
  • [] I have performed a self-review of my own code
  • [] I have commented my code, particularly in hard-to-understand areas
  • [] I have removed any unnecessary comments or console logging
  • [] I have made corresponding changes to the documentation (if required)
  • [] I have addressed accessibility, if needed
  • [] I have followed best practices, e.g. NativeBase approaches and theming
  • [] I have checked the app in dark mode, if making front-end design changes
  • [] My changes generate no new warnings
  • [] I have added tests that prove my fix is effective or that my feature works
  • [] New and existing unit tests pass locally with my changes
  • [] I have updated the version numbers in package.json files in the app and/or api directories as needed

@dvdjms dvdjms changed the base branch from main to develop November 27, 2024 22:39
@CatMac228
Copy link
Collaborator

No longer required.

@CatMac228 CatMac228 closed this Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants