SVA-403 Adds authentication API #200
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roryf
commented
Oct 16, 2023
| @@ -1,11 +1,13 @@ | |||
| const express = require('express'); | |||
| const express = require("express"); | |||
There was a problem hiding this comment.
Prettier decided everything needed double quotes, will update once #198 lands
DJMF2015
approved these changes
Oct 19, 2023
There was a problem hiding this comment.
@roryf i have taken a look over the code changes and run the unit tests (all of which pass). I can't see anything that stands out that requires needing to be changed. I appreciate there is further work to do with Cognito going forward. Looks great work and thanks for doing this. Happy to approve.
4 tasks
|
Merging now as doesn't break existing functionality, even though new endpoints will currently fail. |
roryf
added a commit
that referenced
this pull request
Oct 27, 2023
# Description Authentication services within app. Adds `AuthProvider` which is configured at app level and can be consumed in any component via `useAuth` hook. Added a placeholder example of detecting auth state in `ProfileContainer` There is an underlying `AuthClient` class which handles specific API interaction and storage of auth credentials, which uses [`expo-secure-store`](https://docs.expo.dev/versions/latest/sdk/securestore/). This also manages automatically refreshing auth tokens when access token expires, and handling transient network errors (which will happen a lot). Also configured jest correctly so we can add tests, and removed unused `app/__tests__` directory (I strongly prefer test files to sit with the file under test). Rejigged the app CI build too so it runs the tests, and lints all files not just changed (not convinced this worked correctly tbh). I would very much like to revisit the different eslintrc configs at some point, and the need for questionably useful (IMHO) file comments. Depends on backend in #200 ## Type of change Please delete options that are not relevant - [ ] Bug fix (non-breaking change which fixes an issue) - [x] New Feature (non-breaking change which adds functionality) - [ ] Breaking change(fix or feature that would cause existing functionality to not work as expected) - [ ] This change requires a documentation update # Testing locally No user-facing features added, run the app, check nothing breaks and there are no new console warnings. # Checklist - [] My code follows the style guidelines of this project - [] I have performed a self-review of my own code - [] I have commented my code, particularly in hard-to-understand areas - [] I have removed any unnecessary comments or console logging - [] I have made corresponding changes to the documentation (if required) - [] I have addressed accessibility, if needed - [] I have followed best practices, e.g. NativeBase approaches and theming - [] I have checked the app in dark mode, if making front-end design changes - [] My changes generate no new warnings - [] I have added tests that prove my fix is effective or that my feature works - [] New and existing unit tests pass locally with my changes - [] I have updated the version numbers in `package.json` files in the [app](DEPLOYMENT.md#app-deployment) and/or [api](DEPLOYMENT.md#api-deployment-on-aws) directories as needed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
https://sta2020.atlassian.net/browse/SVA-403
Adds
/authendpoints to support Cognito-based authentication in the app.Requires config updates to set Cognito env vars, depends on setting up Cognito correctly.
Type of change
Please delete options that are not relevant
Testing locally
Won't currently work locally or otherwise...
Checklist
package.jsonfiles in the app and/or api directories as needed