Improve maplibre usability #294
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On my phone at least, the text on maps is too small and the roads too narrow to easily read. Zooming in doesn't help with this as they are still small, just spread further apart. Changing the pixelRatio on the map to be 4.0 results in larger text, icons and roads which is better size wise. The rendering is a bit 'soft', presumably because it's being rendered at 1/16th size and then scaled up, but it's still an overall win.
Rotating the whole map was proving hard work for lower power phones, so switch to our mode where the icon showing the user location rotates instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were a couple of issues with the way in which our GUI map was rendered:
pixelRatiowhich means that the map is now rendered as if the DPI were a quarter of it's previous value and then scaled up. This gives a slightly "soft" look, but at least everything is larger.