Adjust vectorTileToGeoJson to not use transportation_name layer #261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We've added names to all lines that have a neam in the transportation layer and so we no longer need to create a dictionary from the transportation_name layer. We do this because that layer had merged lines which lost OSM ids and made de-duplication impossible. The names are only stored once in the MVT so it's a fairly efficient addition. I've also added some more test tiles to increase testing coverage.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've added names to all lines that have a neam in the transportation layer and so we no longer need to create a dictionary from the transportation_name layer. We do this because that layer had merged lines which lost OSM ids and made de-duplication impossible. The names are only stored once in the MVT so it's a fairly efficient addition.
I've also added some more test tiles to increase testing coverage.