Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Smoke testing #186

Closed
wants to merge 10 commits into from
Closed

Smoke testing #186

wants to merge 10 commits into from

Conversation

ms14981
Copy link
Contributor

@ms14981 ms14981 commented Mar 27, 2023

Things to note:

  • The package versions for the generators are not correct in the logs: Version numbers are not updated in package jsons #191
  • The generator-options command targets the JS generator, and assumes a --moduleFormat option. If this ever changes, the smoke test will fail.
  • The test-generators command targets the TS generators and assumes that all scenarios should be passing. This may not be true, e.g. in the development of a new feature file. Can this be shown as a warning, instead of a failure?
  • The forge command assumes the C# generator can successfully run the forge command on the PetStore. It also assumes that the PetStore API server is up when the command is run. We could change to using a local test schema.
  • The smoke test could be expanded to test all generators on all commands. Maybe one smoke test for each generator (three commands per generator).
  • This smoke test has highlighted that the relative paths work differently in the generator-options command and the test-generators command, which is confusing: JS vs TS: Relative paths are treated differently in different commands #195

Success case (e.g. https://github.com/ScottLogic/openapi-forge/actions/runs/4552435246/jobs/8027766468):
image

Failure case (e.g. https://github.com/ScottLogic/openapi-forge/actions/runs/4552118020/jobs/8027052646):
image

@ms14981 ms14981 force-pushed the smoke branch 19 times, most recently from d2153bd to 0553f3a Compare March 27, 2023 14:19
@ms14981 ms14981 force-pushed the smoke branch 6 times, most recently from c9e8c6d to fecdec7 Compare March 27, 2023 15:17
@ms14981 ms14981 force-pushed the smoke branch 3 times, most recently from 3ef15ff to 57e6543 Compare March 27, 2023 16:07
@ms14981 ms14981 force-pushed the smoke branch 5 times, most recently from c3c7fad to 18a17b4 Compare March 28, 2023 09:45
@ms14981 ms14981 force-pushed the smoke branch 5 times, most recently from 61a64f3 to 26a5992 Compare March 29, 2023 08:56
@ms14981 ms14981 changed the title DO NOT REVIEW - Smoke testing Smoke testing Mar 29, 2023
@ms14981
Copy link
Contributor Author

ms14981 commented Apr 14, 2023

Closing in favour of #194

@ms14981 ms14981 closed this Apr 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant