Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add localdate type and add mapper module detect #45

Merged
merged 3 commits into from
Mar 30, 2023
Merged

feat: add localdate type and add mapper module detect #45

merged 3 commits into from
Mar 30, 2023

Conversation

gkocak-scottlogic
Copy link
Collaborator

  • Add localdate parsing
  • Jackson parse support for date types by adding module registering

ms14981
ms14981 approved these changes Mar 23, 2023
View reviewed changes
Copy link
Contributor

@ms14981 ms14981 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. We could hold off on this until the question about changes to the feature are resolved, or we could merge now, up to you.

@gkocak-scottlogic
Copy link
Collaborator Author

It's fine to wait a bit 👍

@gkocak-scottlogic
Copy link
Collaborator Author

With 4a3808a this PR is not compatible with ScottLogic/openapi-forge#187 to address the issue ScottLogic/openapi-forge#185.

@gkocak-scottlogic
Copy link
Collaborator Author

This fixes #38 as well.

@gkocak-scottlogic gkocak-scottlogic merged commit fadde30 into main Mar 30, 2023
@gkocak-scottlogic gkocak-scottlogic deleted the fix-local-date-serde branch March 30, 2023 15:36
@gkocak-scottlogic gkocak-scottlogic mentioned this pull request Mar 30, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ms14981 ms14981 ms14981 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gkocak-scottlogic @ms14981