feat: capped minter v2 time controls #13
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Open
5 tasks
marcomariscal
force-pushed
the
feat/capped-minter-v2-close
branch
from
3fcf95b to
bceb0f7
Compare
alexkeating
reviewed
Dec 11, 2024
| // Using uint32 for time controls to prevent overflows in the ZkToken contract regarding block numbers needing to be | ||
| // casted to uint32. | ||
| _startTime = bound(_startTime, vm.getBlockTimestamp(), type(uint32).max - 1); | ||
| _expirationTime = bound(_expirationTime, _startTime + 1, type(uint32).max); |
There was a problem hiding this comment.
tried, but doesn't work cuz of the block num casting
alexkeating
reviewed
Dec 11, 2024
| uint256 _invalidExpirationTime | ||
| ) public { | ||
| _cap = bound(_cap, 0, MAX_MINT_SUPPLY); | ||
| _startTime = bound(_startTime, vm.getBlockTimestamp() + 1, type(uint256).max - 1); |
There was a problem hiding this comment.
I would warp to a random time and then make startTime block.timestamp + 1
There was a problem hiding this comment.
And apply a similar idea to the next test
There was a problem hiding this comment.
I would warp to a random time and then make startTime block.timestamp + 1
i reworked this test to be more clear: d1a7306
lemme know how that works
There was a problem hiding this comment.
and here i made updates too:
|
|
||
| ZkCappedMinterV2 cappedMinter = createCappedMinter(_admin, _cap); | ||
| ZkCappedMinterV2 cappedMinter = _createCappedMinter(_admin, _cap, _startTime, _expirationTime); |
There was a problem hiding this comment.
This is an example where maybe moving this to a helper could make things a little cleaner
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.