feat: capped minter v2 close #12
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
marcomariscal
force-pushed
the
feat/capped-minter-v2-pause
branch
2 times, most recently
from
ca259f4 to
004c789
Compare
marcomariscal
force-pushed
the
feat/capped-minter-v2-close
branch
from
3fcf95b to
bceb0f7
Compare
alexkeating
reviewed
Dec 11, 2024
| /// @dev Once closed, the contract cannot be reopened and all minting operations will be permanently blocked. | ||
| /// @dev Only callable by accounts with the PAUSER_ROLE. | ||
| function close() external { | ||
| _checkRole(PAUSER_ROLE, msg.sender); |
There was a problem hiding this comment.
I think we only want the admin to be able to close
| @@ -45,6 +51,7 @@ contract ZkCappedMinterV2 is AccessControl, Pausable { | |||
|
|
|||
| /// @notice Unpauses token minting | |||
| function unpause() external { | |||
| _revertIfClosed(); | |||
There was a problem hiding this comment.
It don't think we need to revert here, since unpausing will have no effect right?
There was a problem hiding this comment.
yee you're right:
| function close() external { | ||
| _checkRole(PAUSER_ROLE, msg.sender); | ||
| closed = true; | ||
| _pause(); |
There was a problem hiding this comment.
Why pause here as well?
There was a problem hiding this comment.
ah yep unnecessary:
| uint256 _amount | ||
| ) public { | ||
| _cap = bound(_cap, 0, MAX_MINT_SUPPLY); | ||
| vm.assume(_cap > 0); |
There was a problem hiding this comment.
Same as last pr take a look at some of these assumes
There was a problem hiding this comment.
cleaned up in feat/capped-minter-v2-pause and some here as well.
…ting default admin string error
Co-authored-by: Alexander Keating <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.