Estimate bundle transfer fee #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wildmolasses
force-pushed
the
estimate-fee
branch
3 times, most recently
from
d8f89bc to
bde3beb
Compare
apbendi
reviewed
Jun 11, 2021
apbendi
reviewed
Jun 11, 2021
apbendi
reviewed
Jun 11, 2021
apbendi
reviewed
Jun 11, 2021
apbendi
reviewed
Jun 11, 2021
…t.. updated zeneth-js and frontend package.json to include @uniswap/token-lists as they both now need it
Signed-off-by: wildmolasses <[email protected]> Signed-off-by: Matt Solomon <[email protected]>
Signed-off-by: wildmolasses <[email protected]>
Signed-off-by: Matt Solomon <[email protected]>
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First attempt at estimating fee.. added new estimateFee method to zeneth-js that could be called by the fronted and a test for it that basically simple runs the method, since we're not mocking out the Gasnow and Coingecko API calls we can't yet verify if the calculation is correct. Also did the fee calculation in a step by step inefficient approach.. not sure if it's right .. still has a number of console logs in here.. looking for feedback if I'm at least on the right path.