Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch to custom errors #76

Merged
merged 2 commits into from
Dec 6, 2024
Merged

Switch to custom errors #76

merged 2 commits into from
Dec 6, 2024

Conversation

davidlaprade
Copy link
Contributor

Fixes #73

@davidlaprade davidlaprade marked this pull request as ready for review December 5, 2024 21:48
alexkeating
alexkeating approved these changes Dec 6, 2024
View reviewed changes
Copy link
Contributor

@alexkeating alexkeating left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm, fix the build before merging

@davidlaprade
Copy link
Contributor Author

Thanks!

Seems like something changed in zgosalvez/github-actions-report-lcov that reduced our coverage from 92.5% to 91.6%. I just ran master and it's broken there too. So I'm just going to reduce the target coverage number to get things green.

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 6, 2024

Coverage after merging custom-errors into master will be

91.67%

Coverage Report
FileStmtsBranchesFuncsLinesUncovered Lines
src
   FlexVotingClient.sol100%100%100%100%
   FractionalPool.sol79.63%70.59%73.33%82.89%107, 109, 111, 114, 190–191, 193–195, 198, 202, 238–239, 78, 80, 82–83, 85
   GovernorCountingFractional.sol94.59%76.92%100%98.04%184, 186, 188, 191

@davidlaprade davidlaprade merged commit a4a17c1 into master Dec 6, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexkeating alexkeating alexkeating approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Convert require statements with errors to throw custom error types
2 participants
@davidlaprade @alexkeating