Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch back to nightly build of foundry #75

Merged
merged 1 commit into from
Nov 27, 2024
Merged

Conversation

davidlaprade
Copy link
Contributor

@davidlaprade davidlaprade commented Nov 21, 2024

Remappings were causing the issue that broke CI a few days ago. Figured it out by making a minimal repro here

This was caused by a bug in foundry, reported here foundry-rs/foundry#9375 and fixed here foundry-rs/foundry#9379

@davidlaprade davidlaprade marked this pull request as ready for review November 21, 2024 17:06
Copy link

Coverage after merging foundry-ci-issue into master will be

92.54%

Coverage Report
FileStmtsBranchesFuncsLinesUncovered Lines
src
   FlexVotingClient.sol100%100%100%100%
   FractionalPool.sol80.65%70.59%73.33%85.25%107, 109, 111, 114, 191, 194–195, 198, 202, 239, 80, 82–83, 85
   GovernorCountingFractional.sol93.75%76.92%100%97.56%184, 186, 188, 191

Copy link
Member

@apbendi apbendi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@davidlaprade davidlaprade merged commit 1a3e644 into master Nov 27, 2024
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants