Add FlexVotingClient Invariant Tests #72
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidlaprade
changed the base branch from
improve-flex-client-test-structure-#69
to
master
davidlaprade
force-pushed
the
invariants
branch
2 times, most recently
from
ca4b5b6 to
d44bf40
Compare
apbendi
reviewed
Nov 20, 2024
There was a problem hiding this comment.
Hey @davidlaprade, I know this is in draft but I had some time to take a look and leave some preliminary thoughts. Looking good overall! Will be nice to have an invariant suite for this.
davidlaprade
force-pushed
the
invariants
branch
from
c56f115 to
834fcf0
Compare
|
Weirdly test coverage is ... down(?) because of a PR that only adds... tests 🤔 |
Otherwise no one will have weight to vote
davidlaprade
force-pushed
the
invariants
branch
from
04638eb to
a03cc50
Compare
davidlaprade
commented
Dec 6, 2024
davidlaprade
commented
Dec 6, 2024
davidlaprade
commented
Dec 6, 2024
alexkeating
approved these changes
Dec 10, 2024
|
Coverage after merging invariants into master will be
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tried to keep the handler as simple as I could, but it's more complicated than I'd like.
To help me reason about the reverts/failures I was seeing in my invariant tests, I ended up needing to write tests for the handler functions. This helped me catch a lot of bugs in the handler, but it made this PR quite a bit bigger than I'd have liked.
If there are important invariants you think I've missed, please lmk! I'm sure there are some I haven't thought of.