Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(shim): Restore original path for JAR cmd #6030

Merged
merged 2 commits into from
Jun 26, 2024
Merged

fix(shim): Restore original path for JAR cmd #6030

merged 2 commits into from
Jun 26, 2024

Conversation

niheaven
Copy link
Member

@niheaven niheaven commented Jun 25, 2024

Description

Use pushd and popd to restore cmd path

Motivation and Context

How Has This Been Tested?

image

Checklist:

  • I have read the Contributing Guide.
  • I have ensured that I am targeting the develop branch.
  • I have updated the documentation accordingly.
  • I have updated the tests accordingly.
  • I have added an entry in the CHANGELOG.

@davidpatel0
Copy link

This does not resolve the issue, cd shouldn't be used at all. Another problem with the current state (that this PR doesn't fix) is that using relative paths with .jar shims is broken (as they are being resolved from scoop\apps\X directory and not from the real working directory.
I will add this problem to the original issue.

@niheaven
Copy link
Member Author

Yes, there are some drawbacks to this fix and using pushd/popd, but the working directory is necessary for some jar applications.

Perhaps there is a better solution, but for now, use this as a temporary bug fix.

@niheaven niheaven merged commit 93359a4 into develop Jun 26, 2024
2 checks passed
@niheaven niheaven deleted the fix-shim branch June 26, 2024 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants