-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge branch 'develop' into 'master' #4594
Conversation
Use newer function - fixes #4534
Add scoop cat command
Co-authored-by: Hsiao-nan Cheung <[email protected]>
feat(shim): ps1 shim hotfix
* show manifest on installation * Inline function * Update install.ps1 Co-authored-by: Rashil Gandhi <[email protected]>
* Added the check for the Windows version. * Apply suggestions from code review Co-Authored-By: Jakub Čábera <[email protected]> * Additional lines added by GitHubs suggestion system removed. Function for the version check removed. If-condition adjusted to check for Major and Build version. * TIL Windows 8.1 = major version 6, Windows 10 = major version 10. * Update diagnostic.ps1 Co-authored-by: Jakub Čábera <[email protected]> Co-authored-by: Ross Smith II <[email protected]>
* chore(config): Document all configuration options * Update README.md * Update scoop-config.ps1 * Update scoop-config.ps1 * Update scoop-config.ps1 * Add env vars
Useful when Scoop installs dependencies and shows their manifests first
Regarding #4528 (comment), I think we should do something about it - otherwise any manifest without URL will fail. See #4285. |
For something like meta manifests that without url, a lots of work to support them should be done, and IMO it is out of scope of these PRs. |
Okay, but we should still do something about the |
Not sure if it's related but AppVeyor start to fail after this is merged. [1] [2] [3]
Is this related to #4528 ? or |
Also, |
"Merge' is off in this repo 😢 Indeed, 'develop' and 'master' are identical after this merge, and reverse merge from 'master' to 'develop' should be done after such merge. Do it next time or enable 'merge commits' in the repo. |
Related PRs: - ScoopInstaller#4531 @filmor - ac71fcc @niheaven - ScoopInstaller#4535 @rashil2000 - ScoopInstaller#4522 @pratikpc - ScoopInstaller#4550 @niheaven - ScoopInstaller#4528 @niheaven - ScoopInstaller#4532 @MrNuggelz - ScoopInstaller#4155 @MrNuggelz Co-authored-by: @rashil2000 - ScoopInstaller#4581 @niheaven - fb496c4 @rashil2000 - ScoopInstaller#4543 @rashil2000 Co-authored-by: @niheaven - ScoopInstaller#4555 @rashil2000 - 3c90d1a @rashil2000 - 2ec00d5 @rashil2000 - ScoopInstaller#4567 @rashil2000 - cbe29ed @rashil2000 - ScoopInstaller#4570 @niheaven - ScoopInstaller#4582 @niheaven - ScoopInstaller#4571 @niheaven - ScoopInstaller#3244 @nickbudi - ScoopInstaller#3821 @jfastnacht Co-authored-by: @rasa - ScoopInstaller#4578 @tukanos - ScoopInstaller#4579 @rashil2000 Co-authored-by: Hsiao-nan Cheung <[email protected]> Co-authored-by: Rashil Gandhi <[email protected]> Co-authored-by: Jakub Čábera <[email protected]> Co-authored-by: Ross Smith II <[email protected]> Co-authored-by: Benedikt Reinartz <[email protected]> Co-authored-by: Joris <[email protected]> Co-authored-by: Pratik Chowdhury <[email protected]> Co-authored-by: Rashil Gandhi <[email protected]> Co-authored-by: nickbudi <[email protected]> Co-authored-by: Julian <[email protected]> Co-authored-by: tukanos <[email protected]>
Related PRs:
Invoke-ExternalCommand
#4570 @niheavenFixed or closed issues: