-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Option to skip hash validation and error message improvements #2260
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allows users to install an app when the manifest provides an outdated hash
- returns a message with a link to the buckets GitHub repository - clicking on the link opens a new issues with a predefined title
- this removes the unreadable robocopy error dumps
rasa
approved these changes
May 16, 2018
@@ -246,7 +246,7 @@ function movedir($from, $to) { | |||
|
|||
$out = robocopy "$from" "$to" /e /move | |||
if($lastexitcode -ge 8) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps:
throw "Could not find '$(fname $from)'! (error $lastexitcode)"
?
brandon93s
approved these changes
May 19, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice, I'm a fan of the issue links when an error occurs. 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
show_app()
function for displayingapp/bucket@version
-s
|--skip
) to skip hash validation onscoop install
andscoop update
to allow installation when a manifest provides an outdated hashnew_issue_msg()
function for nicer error messages with a link to the buckets repository. clicking on the link opens a new issue with a predefined titlerobocopy
output when file moving fails and usenew_issue_msg()
new_issue_msg()
Hm, maybe I put too much in this pull-request ... one change leads to another. 🤷♂️ 😁
Example output:
Ultimate goal: Use GitHub Issue API to find reported hash check errors and let Excavator resolve them automagically.