Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sttr: add version 0.2.12 #3123

Closed
wants to merge 3 commits into from

Conversation

abhimanyu003
Copy link

@tech189
Copy link
Member

tech189 commented Dec 26, 2021

Hi! Thanks for your PR, please could you follow the contribution guide and give some details about the popularity of this program? Next time it would be great if you could create an issue for discussion first :) At a glance it seems a popular program but I will take a closer look tomorrow. Could you also please fix the manifest so that it passes the checks?

bucket/sttr.json Outdated Show resolved Hide resolved
bucket/sttr.json Outdated Show resolved Hide resolved
bucket/sttr.json Outdated Show resolved Hide resolved
@rashil2000
Copy link
Member

#2859 (comment)

@abhimanyu003
Copy link
Author

abhimanyu003 commented Dec 26, 2021

Hello, @tech189 and @rashil2000 thanks so much for your feedback and suggestions.
It's command-line software so I thought it will be allowed.
Few points: It's not on 500 starts yet, but it was trending 3 on ProductHunt https://www.producthunt.com/posts/sttr
It's not downloading anything or opening up any ports or runs in the background, security is not an issue here.

I tried to fix the manifest as per review comments but somehow it keeps on failing.

Please let me know your thoughts.

@rashil2000
Copy link
Member

There's good reason why we insist on contributors opening issues first for any PR, so that such discussions can be had.

It's command-line software so I thought it will be allowed.

It's not the only criterion.

It's not downloading anything or opening up any ports or runs in the background, security is not an issue here.

We know, we can all see the source code there :)

The popularity/age criterion is present to establish a base level of trust. The release artifacts an author puts on their GitHub repo can be modified, even if they're released through an automated process (like GitHub Actions).

I tried to fix the manifest as per review comments but somehow it keeps on failing.

Our CI is broken as of now, you can ignore it.

Please let me know your thoughts.

If you insist, you can shift this PR to Extras bucket.

@abhimanyu003
Copy link
Author

Sure I will look forward to adding it there. Currently closing this PR.

@tech189
Copy link
Member

tech189 commented Dec 27, 2021

If it doesn’t make it into the Extras bucket, it’s very easy to set up a bucket for your own apps. It would only be one extra cmd for your users to run to install.

@rashil2000
Copy link
Member

Sure I will look forward to adding it there.

Hey @abhimanyu003 :)
Any updates?

@tech189
Copy link
Member

tech189 commented Dec 31, 2021

I added it to my bucket in the meantime, just run the following:

scoop bucket add tech189 https://github.com/tech189/tech189-bucket

Then install with:

scoop install sttr

@rashil2000
Copy link
Member

Interesting!

I'd like to add that we have made a template repository for making personal buckets very easily - https://github.com/ScoopInstaller/BucketTemplate - which has several advantages.

@tech189
Copy link
Member

tech189 commented Jan 1, 2022

Oh, I didn't know about that template! I'm going to try migrating my bucket to it by copying what my bucket doesn't have.

@tech189
Copy link
Member

tech189 commented Jan 6, 2022

@rashil2000 just to let you know, I've successfully migrated and set up CI tests in my bucket!

@rashil2000
Copy link
Member

Nice! 😃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants