-
-
Notifications
You must be signed in to change notification settings - Fork 977
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sttr: add version 0.2.12 #3123
sttr: add version 0.2.12 #3123
Conversation
abhimanyu003
commented
Dec 25, 2021
- I have read the Contributing Guide.
Hi! Thanks for your PR, please could you follow the contribution guide and give some details about the popularity of this program? Next time it would be great if you could create an issue for discussion first :) At a glance it seems a popular program but I will take a closer look tomorrow. Could you also please fix the manifest so that it passes the checks? |
Hello, @tech189 and @rashil2000 thanks so much for your feedback and suggestions. I tried to fix the manifest as per review comments but somehow it keeps on failing. Please let me know your thoughts. |
There's good reason why we insist on contributors opening issues first for any PR, so that such discussions can be had.
It's not the only criterion.
We know, we can all see the source code there :) The popularity/age criterion is present to establish a base level of trust. The release artifacts an author puts on their GitHub repo can be modified, even if they're released through an automated process (like GitHub Actions).
Our CI is broken as of now, you can ignore it.
If you insist, you can shift this PR to Extras bucket. |
Sure I will look forward to adding it there. Currently closing this PR. |
If it doesn’t make it into the Extras bucket, it’s very easy to set up a bucket for your own apps. It would only be one extra cmd for your users to run to install. |
Hey @abhimanyu003 :) |
I added it to my bucket in the meantime, just run the following:
Then install with:
|
Interesting! I'd like to add that we have made a template repository for making personal buckets very easily - https://github.com/ScoopInstaller/BucketTemplate - which has several advantages. |
Oh, I didn't know about that template! I'm going to try migrating my bucket to it by copying what my bucket doesn't have. |
@rashil2000 just to let you know, I've successfully migrated and set up CI tests in my bucket! |
Nice! 😃 |