mp3tag: Enhance pre_install script, add pre_uninstall script, and change persist

[FlawlessCasual17]

This allows for mp3tag to be added as a shell extension when the user installs this app.

• I have read the Contributing Guide.

[FlawlessCasual17]

/verify

[github-actions]

All changes look good.

Wait for review from human collaborators.

mp3tag

• Description
• License
• Hashes
• Checkver
• Autoupdate

[HUMORCE]

exists restrict of installation

[FlawlessCasual17]

@HUMORCE can you read my comment on the manifest when you have the time?

[HUMORCE]

where is it?

[FlawlessCasual17]

Ok since GitHub will not show comments for whatever stupid reason I'll just paste it here. This is for lines 12 to 19.

@HUMORCE This part of the script will not work without administrator privileges. Should I make this optional instead?

[HUMORCE]

since GitHub will not show comments for whatever stupid reason.

you need to submit review after start a review.

make this optional

yes

[FlawlessCasual17]

/verify

[github-actions]

All changes look good.

Wait for review from human collaborators.

mp3tag

• Description
• License
• Hashes
• Checkver
• Autoupdate

[HUMORCE]

exists restrict of installation

applies to uninstallation also.

for all operations that require admin privileges: use notes or warn() | info() instead, let users execute them manully.

e.g. some items in scoop-checkup need to be executed manually by the user rather than requesting admin privileges to execute when installing Scoop.

Scoop installs programs from the command line with a minimal amount of friction.

src: https://github.com/ScoopInstaller/Scoop#what-does-scoop-do

[FlawlessCasual17]

@HUMORCE I fixed the pre_uninstall script, now it will only ask for administrator privileges if the DLL file is registered.

[redactedscribe]

@Zliced13 Thanks for the enhancements, but for what reason was persist limited to only a select few files? The manifest was correct to back up all of /data/ and /export/, as well as /mp3tag.cfg. These two directories and /mp3tag.cfg is what Mp3tag exports as a backup when you use the File menu "Save configuration" feature. Limiting persist to only a few files within /data/ misses some user-customised files and the same goes for omitting all of /export/.

There is also /Mp3tagSettings.zip which is automatically created after each termination of the application. If there's a good reason behind limiting persist as you have, at minimum /Mp3tagSettings.zip should also be persisted because this contains all of the user's settings (the three items I've mentioned).

Would it be possible that you fix this?

[FlawlessCasual17]

@Zliced13 Thanks for the enhancements, but for what reason was persist limited to only a select few files? The manifest was correct to back up all of /data/ and /export/, as well as /mp3tag.cfg. These two directories and /mp3tag.cfg is what Mp3tag exports as a backup when you use the File menu "Save configuration" feature. Limiting persist to only a few files within /data/ misses some user-customised files and the same goes for omitting all of /export/.

There is also /Mp3tagSettings.zip which is automatically created after each termination of the application. If there's a good reason behind limiting persist as you have, at minimum /Mp3tagSettings.zip should also be persisted because this contains all of the user's settings (the three items I've mentioned).

Would it be possible that you fix this?

If you read my previous comments, you would know why I had to use pre_(un)install scripts to manually copy the files instead of the using the built in persist property.

[redactedscribe]

I see now that you are actually copying the /export/ directory in the pre inst/uninstall lines, but I'm still confused about why you're only persisting a select number of files from within /data/ instead of all of them.

[FlawlessCasual17]

Because not all the files in the /data/ directory need to be copied to the persist folder.

[redactedscribe]

Because not all the files in the /data/ directory need to be copied to the persist folder.

This is the contents of /data/ for me:

• If actions is not persisted, all user created/modified tagging actions will be lost on uninstall.
• If sources is not persisted, all user created/modified source scripts for fetching metadata will be lost on uninstall.
• If genres.ini is not persisted, all user-defined genres tags will be lost on uninstall.
• If tools.ini is not persisted, all user-defined external program paths and parameters will be lost on uninstall.
• empty.mte appears to be a template which I haven't modified, however others may have.
• freedb.src may also be of importance to anyone who may have edited it.

My /data/ folder may not contain all the potential files/folders that Mp3tag can create as user data, I don't know. What I do know is that I'd not want to lose the files which you have chosen to mark as expendable via their omission from the manifest. Backing up /data/ as a whole would avoid losing any of this user data, much of which is important.

[FlawlessCasual17]

Next PR, I will try to add that feature to mp3tag.