Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: Upgrade motor and add pymongo 4.x to test matrix #387

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

alexandervaneck
Copy link

@alexandervaneck alexandervaneck commented Apr 30, 2024

Tests pass locally 🎉 How do the azure pipelines get executed?

Fixes #386

…ase.

This behavior was changed in pytest 7.0 where `setup()` is now only executed
once when the class loads.
In older versions of `pymongo` attributes of Deferred would be None, in newer
versions they raise AttributeError.
@lafrech
Copy link
Collaborator

lafrech commented May 1, 2024

I think the second link in the OP is wrong (278 is an unrelated PR).

Not sure why Azure CI don't run. In my other projects, we have switched to GH actions. Configuring Azure CI is a pain.

It would be nice to update this repo to match the CI settings from marshmallow (pyproject.toml, ruff, GH actions). If you want to take a stab at it, you're very welcome. But don't feel like you have to. However, rather than struggling with Azure, I suggest you don't wait for me to carve some time to do the GH action move and you try to contribute that change. You may want to do that in another PR for clarity. marshmallow is a nice example to get inspiration from.

@alexandervaneck
Copy link
Author

I think the second link in the OP is wrong (278 is an unrelated PR).

You were right - I confused a ticket on txmongo. I've removed the link.

@alexandervaneck
Copy link
Author

Not sure why Azure CI don't run. In my other projects, we have switched to GH actions. Configuring Azure CI is a pain.

It would be nice to update this repo to match the CI settings from marshmallow (pyproject.toml, ruff, GH actions). If you want to take a stab at it, you're very welcome. But don't feel like you have to. However, rather than struggling with Azure, I suggest you don't wait for me to carve some time to do the GH action move and you try to contribute that change. You may want to do that in another PR for clarity. marshmallow is a nice example to get inspiration from.

Thank you for clarifying. I unfortunately don't have the time to fixup the build process. 🙏 So I suppose this will have to wait until you have time.

@ggdupont
Copy link

ggdupont commented Jun 4, 2024

Any chance to see this PR merged soon? or should we fork?

@lafrech
Copy link
Collaborator

lafrech commented Jun 4, 2024

I don't use umongo anymore but I'm happy to merge PRs. People seriously tempted to fork are very welcome to join in.

Ideally I'd fix/update CI before merging. Anyone willing to copy the CI config from marshmallow, that would be fantastic.

We could merge this change before that but the CI needs to be fixed at some point anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[dependencies] Upgrade pymongo>4 and motor>3.
4 participants