Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Linus fixing #92

Merged
merged 7 commits into from
Jun 2, 2020
Merged

Linus fixing #92

merged 7 commits into from
Jun 2, 2020

Conversation

talavis
Copy link
Contributor

@talavis talavis commented Jun 1, 2020

  • Fix missing alt texts
  • Rename Elixir logo on bioinformatics page from nbis logo to elixir
  • Increase contrast of links (maybe too much?)

@talavis talavis requested a review from ewels June 1, 2020 20:19
@ewels
Copy link
Contributor

ewels commented Jun 2, 2020

Interesting! I always thought that empty alt attributes were a Bad Thing. I tried switching them so that they said the language name instead, but then I got a warning that the content was too similar to what was around it. Then I realised that the empty alt attribute was being flagged as a feature:

Why It Matters
If an image does not convey content or if the content of the image is conveyed elsewhere (such as in a caption or nearby text), the image should have empty/null alternative text (alt="") to ensure that it is ignored by a screen reader and is hidden when images are disabled or unavailable.

Cool!

@ewels
Copy link
Contributor

ewels commented Jun 2, 2020

I tweaked the link colour ever so slightly more after poking around the web a bit. In the end I took the link colour from the EBI site (which passes the test) and made it slightly lighter (still passing).

Ironically, I think that the default Bootstrap link colour actually has better contrast for most users - at least, between regular text and links. But I think that this colour is fine and hopefully works well for everyone.

Copy link
Contributor

@ewels ewels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ewels ewels merged commit 5373540 into develop Jun 2, 2020
@ewels ewels deleted the linus-fixing branch June 2, 2020 06:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants