Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix accessibility reported by pa11y #1179

Merged
merged 1 commit into from
Aug 26, 2024
Merged

Fix accessibility reported by pa11y #1179

merged 1 commit into from
Aug 26, 2024

Conversation

senthil10
Copy link
Contributor

These are accessibility issues reported by pa11y. These are not raised by wave, none of this have any affect visually or functionally, but it is a better change code wise.

Issued addressed:

  • Duplicate id in same page
  • Missing title for iframes

@senthil10 senthil10 requested a review from a team August 22, 2024 11:23
@Ziip-dev Ziip-dev self-requested a review August 22, 2024 14:10
Copy link
Member

@Ziip-dev Ziip-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good :)

@Ziip-dev Ziip-dev merged commit 7ed4556 into develop Aug 26, 2024
3 checks passed
@Ziip-dev Ziip-dev deleted the pa11y_accessibility branch August 26, 2024 13:47
Ziip-dev added a commit that referenced this pull request Aug 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants