Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI tests #116

Merged
merged 3 commits into from
Jun 3, 2020
Merged

CI tests #116

merged 3 commits into from
Jun 3, 2020

Conversation

ewels
Copy link
Contributor

@ewels ewels commented Jun 3, 2020

Continuous integration tests - validate markdown style using markdownlint-cli

Rules: https://github.com/DavidAnson/markdownlint/blob/master/doc/Rules.md

@talavis
Copy link
Contributor

talavis commented Jun 3, 2020

I guess I can't accept it since it failed ;)

@ewels
Copy link
Contributor Author

ewels commented Jun 3, 2020

This should now make each pull-request and commit have an automated test which checks the markdown. It will fail for annoying reasons like having trailing spaces at the end of lines, or too many line breaks in a row. However, it will force all contributors to write markdown in the same style, and should catch certain problems before they become an issue.

@ewels
Copy link
Contributor Author

ewels commented Jun 3, 2020

That's weird - why can't it open the config file? Looks fine to me.. 🤔

@ewels
Copy link
Contributor Author

ewels commented Jun 3, 2020

This is an exact copy of the code we use in nf-core eg. here. So I'm not sure why it's failing.. 😕

@ewels
Copy link
Contributor Author

ewels commented Jun 3, 2020

yml not yaml 🤦

@talavis talavis merged commit b092b1c into ScilifelabDataCentre:develop Jun 3, 2020
@ewels ewels deleted the ci-tests branch June 3, 2020 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants