Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated plots of NPC statistics from vega to plotly #1144

Merged
merged 7 commits into from
Jun 12, 2024

Conversation

misterabdullahAziz
Copy link
Contributor

No description provided.

Copy link
Collaborator

@LianeHughes LianeHughes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need minor changes to have links to scripts formatted in the same way was with other dashboards e.g. http://pathogens.se/dashboards/post_covid/. The links should be below the graphs, with the titles on bold. In this case, the weekly graphs should go under the weekly plots and the daily scripts under the daily plots (so that they are separate). The link to the data is also not shown on the Swedish version, so we need to add this.

@misterabdullahAziz
Copy link
Contributor Author

I have updated it with the required changes. Please check the Swedish text for data.

@LianeHughes LianeHughes self-requested a review June 3, 2024 06:50
Copy link
Collaborator

@LianeHughes LianeHughes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awaiting final approval on Swedish text alignment

@LianeHughes LianeHughes merged commit 0dee303 into develop Jun 12, 2024
3 checks passed
@LianeHughes LianeHughes deleted the FREYA-725/Abdullah branch June 12, 2024 05:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants