-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restructured submit-data page, largely according to Karin Nedler's co… #100
Conversation
Co-authored-by: Sebastian-D <[email protected]>
Co-authored-by: Sebastian-D <[email protected]>
Co-authored-by: Sebastian-D <[email protected]>
@pekrau - minor thing, note that you can apply all suggested edits in a PR in a single batch: https://help.github.com/en/github/collaborating-with-issues-and-pull-requests/incorporating-feedback-in-your-pull-request#applying-suggested-changes (Not super obvious, which is why I'm pointing it out - I think this should be the default UI, otherwise you end up with a huge list of commits addressing hundreds of comments on bigger pull-requests) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
@Sebastian-D - will leave it to you to merge after you check again 👍 |
I can't see the merge button so I don't think I am allowed to merge with Triage permission level. |
Interesting - I haven't played with these new GitHub permission levels yet. You were set to |
…mments.