Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restructured submit-data page, largely according to Karin Nedler's co… #100

Merged
merged 4 commits into from
Jun 2, 2020

Conversation

pekrau
Copy link
Contributor

@pekrau pekrau commented Jun 2, 2020

…mments.

content/english/support_services/submit.md Outdated Show resolved Hide resolved
content/english/support_services/submit.md Outdated Show resolved Hide resolved
content/english/support_services/submit.md Outdated Show resolved Hide resolved
@ewels
Copy link
Contributor

ewels commented Jun 2, 2020

@pekrau - minor thing, note that you can apply all suggested edits in a PR in a single batch: https://help.github.com/en/github/collaborating-with-issues-and-pull-requests/incorporating-feedback-in-your-pull-request#applying-suggested-changes

(Not super obvious, which is why I'm pointing it out - I think this should be the default UI, otherwise you end up with a huge list of commits addressing hundreds of comments on bigger pull-requests)

Copy link
Contributor

@ewels ewels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@ewels
Copy link
Contributor

ewels commented Jun 2, 2020

@Sebastian-D - will leave it to you to merge after you check again 👍

@Sebastian-D
Copy link
Contributor

I can't see the merge button so I don't think I am allowed to merge with Triage permission level.

@ewels ewels merged commit a004d39 into ScilifelabDataCentre:develop Jun 2, 2020
@ewels
Copy link
Contributor

ewels commented Jun 2, 2020

Interesting - I haven't played with these new GitHub permission levels yet. You were set to Write, not Triage (you have push access). I just set you to Maintain, will be curious to see if you can merge now.. (can set you as an administrator if not)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants