Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Paul/FREYA 723 #100

Merged
merged 8 commits into from
Jun 28, 2024
Merged

Paul/FREYA 723 #100

merged 8 commits into from
Jun 28, 2024

Conversation

Ziip-dev
Copy link
Member

Add plotly scripts for serology plots generation.

@Ziip-dev Ziip-dev self-assigned this May 15, 2024
@Ziip-dev Ziip-dev requested review from senthil10 and LianeHughes May 15, 2024 15:13
@Ziip-dev Ziip-dev added the enhancement New feature or request label May 15, 2024
@Ziip-dev
Copy link
Member Author

Ziip-dev commented May 17, 2024 •
edited
Loading

Added README.md

@Ziip-dev Ziip-dev requested a review from a team May 20, 2024 09:29
LianeHughes
LianeHughes requested changes May 22, 2024
View reviewed changes
Copy link
Collaborator

@LianeHughes LianeHughes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the cumulative plot, the order of items in the legend should be the same as that in the weekly plot. Also, the right edge of the box in the plot does not show when the plot is in the page (it needs moving a little to the left).

@LianeHughes
Copy link
Collaborator

Perhaps also put ticks on the x-axis so that it is clear that not every date is shown in the text written.

@Ziip-dev
Copy link
Member Author

Thanks for the corrections that went under my radar :)
I'm working on the ticks and the box (might be a screen resolution issue, I'll increase the margin)

@Ziip-dev
Copy link
Member Author

Finally done with the refining of the graphs (see attached screenshot).
I tried to play with nticks to display markers on the x axis for the hidden weeks, but it adds a lot of clutter at the cost of readability, so I prefer it this way. Please feel free to tell me if that is something we want anyway.

If we are all good, I'll rewrite the history locally to get all the commits signed (here and there) before merging the PR.

localhost_1313_dashboards_serology-statistics_

@Ziip-dev Ziip-dev requested a review from LianeHughes June 26, 2024 12:24
Ziip-dev added 4 commits June 26, 2024 17:26
@Ziip-dev
Add devbox development environment files
c1d177f
@Ziip-dev
Add pyproject.toml and poetry.lock files
207d0ec 
Using poetry for dependency and project management
@Ziip-dev
Add weekly-serology-tests.py
5f444ff 
This script uses plotly to create a stacked bar graph from serology
tests data.
@Ziip-dev
Add cumulative-serology-tests.py
e8908d8 
This script uses plotly to create a cumulative line graph from serology
tests data.
@Ziip-dev
Copy link
Member Author

I rebased the entire branch to tidy the commit history up and sign everything again.
On my side, everything is now up to date :)

Ziip-dev and others added 2 commits June 28, 2024 14:04
@Ziip-dev @LianeHughes
Add annotation text box on cumulative graph
fdacbfa 
This annotation shows the total sum of tests and the proportion of
positive tests

Co-authored-by: LianeHughes <[email protected]>
@LianeHughes @Ziip-dev
Update graph legends and displayed range
1dde520 
Make legend titles and item order more consistent and fine-tune the
displayed range so the markers are not cropped
@Ziip-dev Ziip-dev requested a review from LianeHughes June 28, 2024 12:10
@Ziip-dev
Copy link
Member Author

Changed output to stdout 👍

@senthil10 senthil10 merged commit a774504 into main Jun 28, 2024
@Ziip-dev Ziip-dev deleted the Paul/FREYA-723 branch July 1, 2024 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@senthil10 senthil10 senthil10 approved these changes

@LianeHughes LianeHughes Awaiting requested review from LianeHughes

Assignees

@Ziip-dev Ziip-dev

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Ziip-dev @LianeHughes @senthil10